Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16966 )
Change subject: IMPALA-10447: Add a newline when exporting shell output to a file. ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Thanks for fixing this quickly! LGTM, just have a minor question. http://gerrit.cloudera.org:8080/#/c/16966/3/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/16966/3/tests/shell/test_shell_commandline.py@1089 PS3, Line 1089: 'i_item_sk' Is it intended to make this a constant string literal? -- To view, visit http://gerrit.cloudera.org:8080/16966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I078a06c54e0834bc1f898626afbfff4ded579fa9 Gerrit-Change-Number: 16966 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Mon, 25 Jan 2021 02:52:03 +0000 Gerrit-HasComments: Yes
