Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/16949 )
Change subject: IMPALA-9224 (part 1): Blacklist nodes with faulty disks ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/16949/6/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/16949/6/be/src/runtime/query-state.cc@347 PS6, Line 347: #ifndef NDEBUG > I think this should be removed - its doesn't really help much from a perfor Removed. http://gerrit.cloudera.org:8080/#/c/16949/6/common/protobuf/control_service.proto File common/protobuf/control_service.proto: http://gerrit.cloudera.org:8080/#/c/16949/6/common/protobuf/control_service.proto@263 PS6, Line 263: runs > nit: 'ran' Fixed as suggested. http://gerrit.cloudera.org:8080/#/c/16949/6/common/protobuf/control_service.proto@265 PS6, Line 265: spilling_local_faulty_disk > I think this is unnecessarily verbose, how about just 'local_disk_faulty' o Renamed as local_disk_faulty. -- To view, visit http://gerrit.cloudera.org:8080/16949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04bfcb7f2e0b1ef24a5b4350f270feecd8c47437 Gerrit-Change-Number: 16949 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Jan 2021 01:04:45 +0000 Gerrit-HasComments: Yes
