Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16607 )
Change subject: IMPALA-10274: Initialize impala-python as part of the CMake build ...................................................................... Patch Set 4: (3 comments) Seems overall fine, had some minor comments. http://gerrit.cloudera.org:8080/#/c/16607/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16607/4//COMMIT_MSG@19 PS4, Line 19: - Rebuilt and verified that impala-python is not reinitialized Are there any considerations about testing against different OS versions? I guess mostly we're just using python2.7 in most places? http://gerrit.cloudera.org:8080/#/c/16607/4/be/src/codegen/gen_ir_descriptions.py File be/src/codegen/gen_ir_descriptions.py: http://gerrit.cloudera.org:8080/#/c/16607/4/be/src/codegen/gen_ir_descriptions.py@1 PS4, Line 1: #!/usr/bin/env python Maybe comment why this doesn't use impala-python? http://gerrit.cloudera.org:8080/#/c/16607/4/bin/gen_build_version.py File bin/gen_build_version.py: http://gerrit.cloudera.org:8080/#/c/16607/4/bin/gen_build_version.py@1 PS4, Line 1: #!/usr/bin/env python Maybe comment why this doesn't use impala-python? -- To view, visit http://gerrit.cloudera.org:8080/16607 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieff51263c55bd234028fed7101c94b4a928590f0 Gerrit-Change-Number: 16607 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 27 Jan 2021 02:20:35 +0000 Gerrit-HasComments: Yes
