Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17030 )
Change subject: IMPALA-10469: push quickstart to apache repo ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17030/2/docker/publish_images_to_apache.sh File docker/publish_images_to_apache.sh: http://gerrit.cloudera.org:8080/#/c/17030/2/docker/publish_images_to_apache.sh@62 PS2, Line 62: IMAGES+=" impala_quickstart_client impala_quickstart_hms" > What consumes docker-images.txt other than this? Should we just include the I've seen some build tools (internal to Cloudera) that basically intersect the images in docker-images.txt with the image tags generated by the build and then consider those build outputs. We don't build these quickstart images as part of the docker_images target, but I guess that's true of the debug images as well, so maybe it's harmless to add these. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/17030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I535d77e565b73d732ae511d7525193467086c76a Gerrit-Change-Number: 17030 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 09 Feb 2021 01:40:56 +0000 Gerrit-HasComments: Yes
