Bikramjeet Vig has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17028 )

Change subject: IMPALA-10397 : Reduce flakiness in test_single_workload
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Carrying over +2

http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py
File tests/custom_cluster/test_auto_scaling.py:

http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py@54
PS1, Line 54:
> flake8: E501 line too long (91 > 90 characters)
Done


http://gerrit.cloudera.org:8080/#/c/17028/1/tests/custom_cluster/test_auto_scaling.py@60
PS1, Line 60:     metric_val = 
self.impalad_test_service.get_metric_value(TOTAL_BACKENDS_METRIC_NAME)
> Nit: tidier to use a variable for "cluster-membership.backends.total" rathe
Done



--
To view, visit http://gerrit.cloudera.org:8080/17028
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73ea5eb663db6d03832b19ed323670590946f514
Gerrit-Change-Number: 17028
Gerrit-PatchSet: 2
Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Feb 2021 00:24:35 +0000
Gerrit-HasComments: Yes

Reply via email to