Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17054 )
Change subject: IMPALA-10497: Fix flakiness in test_no_fd_caching_on_cached_data. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17054/2/tests/custom_cluster/test_hdfs_fd_caching.py File tests/custom_cluster/test_hdfs_fd_caching.py: http://gerrit.cloudera.org:8080/#/c/17054/2/tests/custom_cluster/test_hdfs_fd_caching.py@168 PS2, Line 168: cluster_size=1 Under the covers, custom cluster test uses bin/start-impala-cluster.py and that script has an option for turning on the data cache (separate from impalad_args). It gives a different directory to each impalad. To use that, you can specify those arguments via start_args and omit the corresponding impalad_args. So, I think we can do something similar to what test_data_cache.py does and use this: impalads_args="--max_cached_file_handles=16 --unused_file_handle_timeout_sec=5 " + "--always_use_data_cache=true" start_args="--data_cache_dir=/tmp --data_cache_size=500MB" and then leave the rest as-is. -- To view, visit http://gerrit.cloudera.org:8080/17054 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I774f9dfea7dcc107c3c7f2b76db3aaf4b2dd7952 Gerrit-Change-Number: 17054 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Feb 2021 20:30:22 +0000 Gerrit-HasComments: Yes
