Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17071 )
Change subject: IMPALA-10501: Hit DCHECK in parquet-column-readers.cc: def_levels_.CacheRemaining() <= num_buffered_values_ ...................................................................... Patch Set 2: (1 comment) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/17071/1/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/17071/1/be/src/exec/parquet/parquet-column-readers.cc@518 PS1, Line 518: max_values = min(max_values, num_buffered_values_); : while (def_levels_.CacheHasNext() && val_count < max_values) { : if (DoesPageFiltering()) { > I think that this is only true of if def_levels_.ReadLevel() was used inste Yeah, I think your proposal is better. And this way we can keep the DCHECK. -- To view, visit http://gerrit.cloudera.org:8080/17071 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic071473e7b315300fd5e163225d3e39735f09c4f Gerrit-Change-Number: 17071 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Feb 2021 15:14:18 +0000 Gerrit-HasComments: Yes
