scar...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/17079 )
Change subject: IMPALA-10510: Change code to help with third party extensions ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17079/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/17079/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1224 PS1, Line 1224: protected > I think it would be useful to update the documentation of this method to de Done. As for those other methods, you are correct. The method loadSchema was changed in a different Jira (sorry, we should have batched them up). The "loadValidWriteIdList" method was already declared as protected. The "loadAllColumnStats" method was in the base "Table" class so it was also declared as protected. -- To view, visit http://gerrit.cloudera.org:8080/17079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4911ddef232301c99ceada4635b72bf4e57ea9c7 Gerrit-Change-Number: 17079 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <scar...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Sat, 20 Feb 2021 14:18:12 +0000 Gerrit-HasComments: Yes
