Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17062 )
Change subject: IMPALA-10504: Add tracing for remote block reads ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/17062/5/be/src/runtime/io/hdfs-file-reader.h File be/src/runtime/io/hdfs-file-reader.h: http://gerrit.cloudera.org:8080/#/c/17062/5/be/src/runtime/io/hdfs-file-reader.h@81 PS5, Line 81: /// Return a string that contains the block indexes and list of hosts where each block resides line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17062/5/be/src/runtime/io/hdfs-file-reader.cc File be/src/runtime/io/hdfs-file-reader.cc: http://gerrit.cloudera.org:8080/#/c/17062/5/be/src/runtime/io/hdfs-file-reader.cc@84 PS5, Line 84: std::string HdfsFileReader::GetHostList(int64_t file_offset, int64_t bytes_to_read) const { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17062/5/be/src/runtime/io/hdfs-file-reader.cc@85 PS5, Line 85: char*** hosts = hdfsGetHosts(hdfs_fs_, scan_range_->file_string()->c_str(), file_offset, bytes_to_read); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/17062/5/be/src/runtime/io/hdfs-file-reader.cc@240 PS5, Line 240: if (FLAGS_fs_trace_remote_reads && expected_local_ && num_remote_bytes_ > 0 && is_first_read) { line too long (101 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17062 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c6a3e92f44813048022edf2b91299b3b0a20257 Gerrit-Change-Number: 17062 Gerrit-PatchSet: 5 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Sun, 21 Feb 2021 21:02:31 +0000 Gerrit-HasComments: Yes
