Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17100 )
Change subject: IMPALA-10527: Fix DiskIoMgrTest.WriteToRemotePartialFileSuccess failed in tsan build ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/17100/5/be/src/runtime/tmp-file-mgr.cc File be/src/runtime/tmp-file-mgr.cc: http://gerrit.cloudera.org:8080/#/c/17100/5/be/src/runtime/tmp-file-mgr.cc@170 PS5, Line 170: TmpFileMgr::~TmpFileMgr() { nit: no need to delete the blank line before this http://gerrit.cloudera.org:8080/#/c/17100/5/be/src/runtime/tmp-file-mgr.cc@1954 PS5, Line 1954: tmp_file_mgr_->GetSpillBufferWaitTimeout()/MICROS_PER_SEC)); The formatting here was correct before -- To view, visit http://gerrit.cloudera.org:8080/17100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6b0435bf0ee580acb5553527c0ed4f3aa806707f Gerrit-Change-Number: 17100 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Wed, 24 Feb 2021 01:21:03 +0000 Gerrit-HasComments: Yes
