Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17078 )
Change subject: IMPALA-10505: Avoid creating misleading audit logs ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17078/5/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/17078/5/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java@73 PS5, Line 73: private boolean hasAccess(AuthorizationContext authzCtx, User user, : PrivilegeRequest request, boolean retainAudits) optional: retainAudits could a member of AuthorizationContext, so we wouldn't need to pass through the whole callchain. http://gerrit.cloudera.org:8080/#/c/17078/5/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/17078/5/tests/authorization/test_ranger.py@1087 PS5, Line 1087: .format(test_db, test_view, grantee_user), user=ADMIN) nit: I think that there should be +4 indent when breaking the line between a string and .format() -- To view, visit http://gerrit.cloudera.org:8080/17078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02f40eb96d6ed863cd2cd88d717c354dc351a64c Gerrit-Change-Number: 17078 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 24 Feb 2021 12:56:48 +0000 Gerrit-HasComments: Yes
