Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17125 )
Change subject: IMPALA-10550: Add External Frontend service port ...................................................................... Patch Set 4: (2 comments) Are there any existing hs2 methods that it might make sense to block for the "external frontend" server? eg. we might want to return an error for ExecuteStatement() from it if the external frontend will never need to call it. That would give us a little more safety in case people accidentally expose this port to the outside world (of course, it would still be possible for bad actors to use the ExecutePlannedStatement interface, but its probably a lot harder to put together a valid TExecRequest to use it than it is to put together a SQL string like ExecuteStatement takes) Also out of curiosity - what's the long run testing plan here? Are we going to have an actual external FE running in the minicluster that can exercise this stuff? http://gerrit.cloudera.org:8080/#/c/17125/4/be/src/rpc/authentication.h File be/src/rpc/authentication.h: http://gerrit.cloudera.org:8080/#/c/17125/4/be/src/rpc/authentication.h@73 PS4, Line 73: AuthProvider* GetExternalFrontendAuthProvider(); Might mention that this is always a NoAuthProvider, or null if external_fe_port is 0 http://gerrit.cloudera.org:8080/#/c/17125/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/17125/4/be/src/service/impala-server.cc@151 PS4, Line 151: "If 0 or less, the External Frontend server is not started."); You should mention that this server is never protected with authentication so users should be careful to not expose this port if they enable it. -- To view, visit http://gerrit.cloudera.org:8080/17125 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I991b5b05e12e37d8739e18ed1086bbb0228acc40 Gerrit-Change-Number: 17125 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <j...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <j...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 26 Feb 2021 21:19:50 +0000 Gerrit-HasComments: Yes
