Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17092 )
Change subject: IMPALA-10524: Changes to HdfsPartition for third party extensions. ...................................................................... Patch Set 10: (2 comments) The change in HdfsTable may introduce an issue. Other changes look good to me. http://gerrit.cloudera.org:8080/#/c/17092/10/be/src/rpc/hs2-http-test.cc File be/src/rpc/hs2-http-test.cc: http://gerrit.cloudera.org:8080/#/c/17092/10/be/src/rpc/hs2-http-test.cc@51 PS10, Line 51: virtual void GetBackendConfig(TGetBackendConfigResp& return_val, Is this used somewhere? http://gerrit.cloudera.org:8080/#/c/17092/10/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/17092/10/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1719 PS10, Line 1719: if (isSchemaLoaded_) return; I don't think we can do this. This means the table schema will only be loaded once. However, when executiing REFRESH or some DDL commands, we need to reload these to update the schema. Here's an example: # Create a table in Impala and run any query on it to make its metadata loaded impala> create table my_tbl (id int, name string); impala> desc my_tbl; # Change its schema in Hive beeline> alter table my_tbl add columns (address string); # Refresh in Impala. Impala should reload its metadata and get the latest schema. impala> refresh my_tbl; impala> desc my_tbl; -- To view, visit http://gerrit.cloudera.org:8080/17092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a792642f27228118ac8f2e8ef98e8ba7aee4a46 Gerrit-Change-Number: 17092 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 01 Mar 2021 13:29:34 +0000 Gerrit-HasComments: Yes