Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17136 )
Change subject: IMPALA-10529: Fix hit DCHECK in DiskIoMgr::AssignQueue in core-s3 build ...................................................................... Patch Set 2: > Patch Set 2: > > (1 comment) Good to see this! I hit the same issue in GCS when working on https://gerrit.cloudera.org/c/17121 I reproduce it using a test in test_queries.py::TestQueries::test_analytic_fns SET default_spillable_buffer_size=8m; SET buffer_pool_limit=47m; SELECT lag(-180, 13) over (ORDER BY t1.int_col ASC, t2.int_col ASC) AS int_col FROM functional_parquet.alltypes t1 CROSS JOIN functional_parquet.alltypes t2 LIMIT 10; This patch fixes my issue. Maybe you can add a test similar to this and only run on S3 builds. -- To view, visit http://gerrit.cloudera.org:8080/17136 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic07945abe65d90235aa8dea92dd3c3821a4f1f53 Gerrit-Change-Number: 17136 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Mar 2021 01:01:08 +0000 Gerrit-HasComments: No