Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17099 )
Change subject: IMPALA-10523: Fix impala-shell crash in printing error messages that contain UTF-8 characters ...................................................................... Patch Set 2: (1 comment) Hi Quanlong, looks good to me, just one minor observation. http://gerrit.cloudera.org:8080/#/c/17099/2/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/17099/2/shell/impala_shell.py@1321 PS2, Line 1321: if sys.version_info.major == 2 and isinstance(msg, unicode): nit: could you add a short one line comment that explains this condition? -- To view, visit http://gerrit.cloudera.org:8080/17099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie10f5b03ecc5877053c2fbada1afaf256b423a71 Gerrit-Change-Number: 17099 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Mar 2021 12:33:11 +0000 Gerrit-HasComments: Yes
