John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17094 )
Change subject: IMPALA-9218: Add support for locally compiled Hive ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17094/2//COMMIT_MSG@23 PS2, Line 23: export HIVE_VERSION_OVERRIDE=3.1.0-SNAPSHOT > If the long lines were for the description of what the patch is doing, that Done http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py@469 PS2, Line 469: use_override_hive = \ : "HIVE_VERSION_OVERRIDE" in os.environ and os.envi > Nit: for this, I think I would break the line right after the first equals, Done http://gerrit.cloudera.org:8080/#/c/17094/2/bin/bootstrap_toolchain.py@471 PS2, Line 471: > flake8: E501 line too long (91 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/17094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21892c153c445e3a5d93f2bc8f5e0b799929dd34 Gerrit-Change-Number: 17094 Gerrit-PatchSet: 3 Gerrit-Owner: John Sherman <j...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@cloudera.com> Gerrit-Comment-Date: Sun, 07 Mar 2021 16:31:09 +0000 Gerrit-HasComments: Yes