Yida Wu has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/17140 )
Change subject: IMPALA-10555: Fix Hit DCHECK in TmpFileGroup::RecoverWriteError ...................................................................... IMPALA-10555: Fix Hit DCHECK in TmpFileGroup::RecoverWriteError The DCHECK error happens when there is an IO error during the spilling process if the scratch directory is in a remote filesystem and doing an error recovery(rewrite). Because currently the DCHECK only consider the file number of local scratch files, it leads to a file number requirement mismatch in the DCHECK. Because the implementation of spilling to the local fs and the remote fs are quite different, for simplify, we don't recover write error for spilling to a remote fs in the current version. Instead, the errors generated during spilling to remote would be returned directly to the upper layer. So, we avoid the DCHECK logic for spilling to remote. Tests: * Added a unit test: TmpFileMgrTest::TestRemoteRemoveBuffer. * Ran Unit Tests: $IMPALA_HOME/be/build/latest/runtime/tmp-file-mgr-test Change-Id: Ifd9aea4bf2fff634ea9a30bf6e87987be4e1c611 --- M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc 2 files changed, 38 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/17140/4 -- To view, visit http://gerrit.cloudera.org:8080/17140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd9aea4bf2fff634ea9a30bf6e87987be4e1c611 Gerrit-Change-Number: 17140 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
