Kurt Deschler has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17122 )

Change subject: IMPALA-10549: Register transactions from external frontend DML
......................................................................


Patch Set 11:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17122/11/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

http://gerrit.cloudera.org:8080/#/c/17122/11/fe/src/main/java/org/apache/impala/service/Frontend.java@2028
PS11, Line 2028: /**
               :    * Opens a new transaction and registers it to the keepalive 
object.
               :    * @param queryCtx context of the query that requires the 
transaction.
               :    * @return the transaction id.
               :    * @throws TransactionException
               :    */
> This comment is really for openTransaction and should be moved, addTransact
Done



--
To view, visit http://gerrit.cloudera.org:8080/17122
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8863b8d9d281a5d164f10de9c5ee52cf3be63db
Gerrit-Change-Number: 17122
Gerrit-PatchSet: 11
Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: John Sherman <j...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Mar 2021 01:00:52 +0000
Gerrit-HasComments: Yes

Reply via email to