John Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17145 )
Change subject: IMPALA-10553: External Frontend CTAS support ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/17145/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17145/4//COMMIT_MSG@12 PS4, Line 12: - When this is set, the external frontend is responsible for : for moving and managing the results > This is correct. I'll update the commit message to make that clearer. Done http://gerrit.cloudera.org:8080/#/c/17145/4/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/17145/4/be/src/exec/hdfs-table-sink.cc@127 PS4, Line 127: staging_dir_ = Substitute("$0/_impala_insert_staging/$1", table_desc_->hdfs_base_dir(), : PrintId(state->query_id(), "_")); : : // Prepare partition key exprs and gather dynamic partition key exprs. : for (size_t i = 0; i < partition_key_expr_evals_.size(); ++i) { : // Remember non-constant partition key exprs for building hash table of Hdfs files. : > I can certainly change everything to be external output rather than externa Done -- To view, visit http://gerrit.cloudera.org:8080/17145 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iae0ea4a832d8281c563427d0d7da1623bfce437b Gerrit-Change-Number: 17145 Gerrit-PatchSet: 7 Gerrit-Owner: John Sherman <j...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Sun, 14 Mar 2021 18:40:41 +0000 Gerrit-HasComments: Yes
