Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17188 )
Change subject: IMPALA-10577: Add retrying of AdmitQuery ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17188/1/be/src/scheduling/remote-admission-control-client.cc File be/src/scheduling/remote-admission-control-client.cc: http://gerrit.cloudera.org:8080/#/c/17188/1/be/src/scheduling/remote-admission-control-client.cc@40 PS1, Line 40: admission_max_retry_time_s I am wondering if it's good to set maximum number of times for retrying RPC call, or set maximum times for retrying RPC call? What's typical time for an admissiond ready to accept request after it's restarted? http://gerrit.cloudera.org:8080/#/c/17188/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/17188/1/tests/custom_cluster/test_admission_controller.py@1385 PS1, Line 1385: assert result.data == ["730"] Could you add another test case for which sleep more than admission_max_retry_time_s before restart admissiond so that retry will fail? -- To view, visit http://gerrit.cloudera.org:8080/17188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bc0cac666bbd613a1143c0e2c4f84d3b0ad003a Gerrit-Change-Number: 17188 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Mar 2021 00:33:44 +0000 Gerrit-HasComments: Yes
