Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/16407 )
Change subject: IMPALA-10116: Allow unwrapping a builtin cast function similar to CastExpr ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16407/3/fe/src/main/java/org/apache/impala/analysis/Expr.java File fe/src/main/java/org/apache/impala/analysis/Expr.java: http://gerrit.cloudera.org:8080/#/c/16407/3/fe/src/main/java/org/apache/impala/analysis/Expr.java@329 PS3, Line 329: public static final com.google.common.base.Predicate<Expr> IS_IS_NULL_PREDICATE = Change name to IS_ISNULL_PREDICATE for consistency. http://gerrit.cloudera.org:8080/#/c/16407/3/fe/src/main/java/org/apache/impala/analysis/Expr.java@339 PS3, Line 339: IS_DISTINCT_FROM_OR_NOT_DISTINCT_PREDICATE = Maybe should add a comment here why we have this variant. -- To view, visit http://gerrit.cloudera.org:8080/16407 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf82b2de78c6a7051ea036062f177d69e2558940 Gerrit-Change-Number: 16407 Gerrit-PatchSet: 3 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Mar 2021 17:43:02 +0000 Gerrit-HasComments: Yes
