Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/17122 )
Change subject: IMPALA-10549: Register transactions from external frontend DML ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/17122/12/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/17122/12/fe/src/main/java/org/apache/impala/service/Frontend.java@2048 PS12, Line 2048: Preconditions.checkState(!queryCtx.isSetTransaction_id()); > Why is it valid that a we might already have a transaction id here when we' I removed this check to resolve the test failure based on this being the existing path and because openTransaction is not called for externally started transactions. I didn't get into the details of what the test was doing. -- To view, visit http://gerrit.cloudera.org:8080/17122 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8863b8d9d281a5d164f10de9c5ee52cf3be63db Gerrit-Change-Number: 17122 Gerrit-PatchSet: 12 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: John Sherman <j...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Mar 2021 23:59:01 +0000 Gerrit-HasComments: Yes
