Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17192 )
Change subject: IMPALA-10579: Avoid infinite loop from remote file iterator ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17192/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java: http://gerrit.cloudera.org:8080/#/c/17192/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@837 PS1, Line 837: IMPALA-1057 IMPALA-10579 http://gerrit.cloudera.org:8080/#/c/17192/1/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@840 PS1, Line 840: if (last_iter_had_exception) { : throw ex; : } I think if the iterator encounters two absence subdirectories continuely, we will throw exception here. E.g. when there are three concurrent INSERTs on the table, the last finished INSERT could fail by this. Could you loop test_insert_stress.py several times to test? -- To view, visit http://gerrit.cloudera.org:8080/17192 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia8b60aab0286390ced364188a24ee78f99073730 Gerrit-Change-Number: 17192 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Thu, 18 Mar 2021 00:38:49 +0000 Gerrit-HasComments: Yes
