Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17168 )
Change subject: IMPALA-10564: Return error when inserting an invalid decimal value ...................................................................... Patch Set 7: When decimal_v2 is set as false, Impala return a warning and insert NULL. So we don't need to introduce another query option. The bug is not related with ABORT_ON_ERROR. Even ABORT_ON_ERROR is set false, we still should abort the query with an error for overflowed decimal value. In first two cases, current code abort the query with an error for invalid decimal value when ABORT_ON_ERROR is set false. To fix the issue, we just return error in table writer if we found got NULL for decimal columns as my patch set 2. Or fix it more aggressively, by replacing "return Status:OK()" with "return state->CheckQueryState())" in HdfsTableSink::Send() and KuduTableSink::Send(). -- To view, visit http://gerrit.cloudera.org:8080/17168 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64ce4ed194af81ef06401ffc1124e12f05b8da98 Gerrit-Change-Number: 17168 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 22 Mar 2021 17:26:01 +0000 Gerrit-HasComments: No
