Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17237 )
Change subject: IMPALA-10619: Minor refactoring of standardize method for analytic functions ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17237/1/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java File fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/17237/1/fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java@833 PS1, Line 833: protected FunctionCallExpr createRewrittenFunction(FunctionName funcName, > This seems a static method for FunctionCallExpr. Nothing special for analyt Right..this was a natural and object-oriented way I could think of where a derived class of AnalyticExpr could override it. The external FE would create something like a new ExternalFEFunctionCallExpr (this is just an example name) which is a derived class of FunctionCallExpr. Making it a static method would prevent the override. I am open to suggestions and will try to think of alternatives. -- To view, visit http://gerrit.cloudera.org:8080/17237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I39e4268c0c5500f09acf98357a80763c28f615c2 Gerrit-Change-Number: 17237 Gerrit-PatchSet: 1 Gerrit-Owner: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Wed, 31 Mar 2021 06:44:24 +0000 Gerrit-HasComments: Yes
