Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17248 )
Change subject: IMPALA-10624: TestIcebergTable::test_alter_iceberg_tables failed by stale file format ...................................................................... Patch Set 1: (1 comment) Patch looks good to me. I left a comment regarding the comment. http://gerrit.cloudera.org:8080/#/c/17248/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/17248/1/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java@177 PS1, Line 177: only be s Not sure if I understand this comment fully. Is this more readable? Returns true if the table property should only be stored in HMS. If false, the property is stored in HMS as well as iceberg? -- To view, visit http://gerrit.cloudera.org:8080/17248 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff8d5d1d90444aba11d47cfce522aaa45a4a74cc Gerrit-Change-Number: 17248 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Wed, 31 Mar 2021 22:38:13 +0000 Gerrit-HasComments: Yes
