Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17258 )
Change subject: IMPALA-10259 (part 2): Fixed DCHECK error for backend in terminal state ...................................................................... IMPALA-10259 (part 2): Fixed DCHECK error for backend in terminal state The previous patch tried to fix the race and make backends avoid to send status report with fragment instance state as "done" and overall_status as OK after fragment instance fails. But it does not work when fragment instance state is updated during generating status report. For failed fragment instance, backend should report the instance as "done" only when overall_statue is reported with error. The final fragment instance state will be reported in final status report. This avoid coordinator to ignore the last status report. Testing: - Manual tests I could only reproduce the situation by adding some artificial delays in the QueryState::ConstructReport() after setting overall_status for the status report when repeatedly running test case test_spilling.py::TestSpillingNoDebugActionDimensions ::test_spilling_no_debug_action. Verified that the issue did not happen after applying this patch. - Passed exhaustive test. Change-Id: Ifd9820f9944a78811ee7acfa5870a9418902b17b --- M be/src/runtime/fragment-instance-state.cc 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/58/17258/2 -- To view, visit http://gerrit.cloudera.org:8080/17258 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ifd9820f9944a78811ee7acfa5870a9418902b17b Gerrit-Change-Number: 17258 Gerrit-PatchSet: 2 Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>
