Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17208 )
Change subject: IMPALA-10591: Handle failed ReleaseQueryBackends rpcs ...................................................................... IMPALA-10591: Handle failed ReleaseQueryBackends rpcs When the admission control service is in use, coordinators will retry failed ReleaseQueryBackends rpcs 3 times before giving up. This can potentially result in resources not being released when they are no longer in use. This patch fixes the issue by automatically releasing all remaining backends when ReleaseQuery is called in the context of the admission control service (either as the result of a ReleaseQUery rpc or when cleaning up a query's resources with the heartbeat mechanism). Testing: - Added a custom cluster test that simulates failed ReleaseQueryBackends rpcs and ensures that query resources are eventually released. Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Reviewed-on: http://gerrit.cloudera.org:8080/17208 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Thomas Tauber-Marshall <tmarsh...@cloudera.com> --- M be/src/scheduling/admission-control-service.cc M be/src/scheduling/admission-controller.cc M be/src/scheduling/admission-controller.h M tests/custom_cluster/test_admission_controller.py 4 files changed, 115 insertions(+), 48 deletions(-) Approvals: Impala Public Jenkins: Verified Thomas Tauber-Marshall: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I22842b2fb8ee170b5e91f12cd83f57a5f5502ae9 Gerrit-Change-Number: 17208 Gerrit-PatchSet: 5 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com>