Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17265 )

Change subject: [PROTOTYPE] IMPALA-10630: Support negative compression levels 
for ZSTD
......................................................................


Patch Set 1:

(13 comments)

http://gerrit.cloudera.org:8080/#/c/17265/1/testdata/bin/generate-schema-statements.py
File testdata/bin/generate-schema-statements.py:

http://gerrit.cloudera.org:8080/#/c/17265/1/testdata/bin/generate-schema-statements.py@489
PS1, Line 489: def build_insert(insert, db_name, db_suffix, file_format, codec, 
compression_type,
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py
File tests/benchmark/report_benchmark_results.py:

http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@425
PS1, Line 425:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@425
PS1, Line 425:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@464
PS1, Line 464:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@464
PS1, Line 464:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@1041
PS1, Line 1041:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/benchmark/report_benchmark_results.py@1041
PS1, Line 1041:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py
File tests/common/test_dimensions.py:

http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@56
PS1, Line 56: ,
flake8: W602 deprecated form of raising exception


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@56
PS1, Line 56: e
flake8: E501 line too long (94 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@60
PS1, Line 60: c
flake8: F841 local variable 'compression_level_int' is assigned to but never 
used


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@62
PS1, Line 62: ,
flake8: W602 deprecated form of raising exception


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@94
PS1, Line 94: ,
flake8: W602 deprecated form of raising exception


http://gerrit.cloudera.org:8080/#/c/17265/1/tests/common/test_dimensions.py@94
PS1, Line 94: l
flake8: E501 line too long (95 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/17265
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I10a7657a479610ccb551162dd8d1247fd2514a6d
Gerrit-Change-Number: 17265
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Fri, 02 Apr 2021 03:16:34 +0000
Gerrit-HasComments: Yes

Reply via email to