Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )
Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17276/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17276/1//COMMIT_MSG@9 PS1, Line 9: For a transcational table, catalogD compares previous and current ValidWriteList to determine more recent version out of the two and reloads table cache accordingly. Because of a bug in ValidWriteIdList comparison, catalogD was not populating table cache with more recent changes. As a result of which we were seeing inconsistencies in read after write into the table. nit: please wrap the commit message lines at 72 chars http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java@752 PS1, Line 752: return Long.signum((a.getInvalidWriteIds()[minLen] - 1) - b.getHighWatermark()); Note that Hive still uses the old version: https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java#L70 -- To view, visit http://gerrit.cloudera.org:8080/17276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc Gerrit-Change-Number: 17276 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <soura...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Apr 2021 20:09:35 +0000 Gerrit-HasComments: Yes
