Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17118 )
Change subject: IMPALA-10488: Add jwt-cpp 0.5.0 to the toolchain ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17118/3/source/jwt-cpp/build.sh File source/jwt-cpp/build.sh: http://gerrit.cloudera.org:8080/#/c/17118/3/source/jwt-cpp/build.sh@33 PS3, Line 33: # jwt-cpp is currently header-only, so it really is only copying files around Should we add header only libraries to native toolchain? We had this dilemma when adding data sketches, and in the end we simply copied the header files to https://github.com/apache/impala/tree/master/be/src/thirdparty I don't have a clear preference here, just curious about your opinion. -- To view, visit http://gerrit.cloudera.org:8080/17118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77aa3b36b45e8ef3c2d7873327948197c2c65d11 Gerrit-Change-Number: 17118 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Apr 2021 07:10:59 +0000 Gerrit-HasComments: Yes
