Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17026 )
Change subject: IMPALA-10640: Support reading Parquet Bloom filters - most common types ...................................................................... Patch Set 25: (182 comments) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h File be/src/thirdparty/xxhash/xxhash.h: http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@70 PS25, Line 70: https://fastcompression.blogspot.com/2019/03/presenting-xxh3.html?showComment=1552696407071#c3490092340461170735 line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@92 PS25, Line 92: * https://fastcompression.blogspot.com/2018/03/xxhash-for-small-keys-impressive-power.html line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@113 PS25, Line 113: # elif defined (__cplusplus) || (defined (__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) /* C99 */) line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@243 PS25, Line 243: # define XXH3_64bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_64bits_reset_withSecret) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@253 PS25, Line 253: # define XXH3_128bits_reset_withSeed XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSeed) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@254 PS25, Line 254: # define XXH3_128bits_reset_withSecret XXH_NAME2(XXH_NAMESPACE, XXH3_128bits_reset_withSecret) line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@270 PS25, Line 270: #define XXH_VERSION_NUMBER (XXH_VERSION_MAJOR *100*100 + XXH_VERSION_MINOR *100 + XXH_VERSION_RELEASE) line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@429 PS25, Line 429: * @param statePtr A pointer to an @ref XXH32_state_t allocated with @ref XXH32_createState(). line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@441 PS25, Line 441: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dst_state, const XXH32_state_t* src_state); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@476 PS25, Line 476: XXH_PUBLIC_API XXH_errorcode XXH32_update (XXH32_state_t* statePtr, const void* input, size_t length); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@628 PS25, Line 628: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dst_state, const XXH64_state_t* src_state); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@631 PS25, Line 631: XXH_PUBLIC_API XXH_errorcode XXH64_update (XXH64_state_t* statePtr, const void* input, size_t length); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@700 PS25, Line 700: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSeed(const void* data, size_t len, XXH64_hash_t seed); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@724 PS25, Line 724: XXH_PUBLIC_API XXH64_hash_t XXH3_64bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize); line too long (120 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@743 PS25, Line 743: XXH_PUBLIC_API void XXH3_copyState(XXH3_state_t* dst_state, const XXH3_state_t* src_state); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@756 PS25, Line 756: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@766 PS25, Line 766: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize); line too long (121 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@768 PS25, Line 768: XXH_PUBLIC_API XXH_errorcode XXH3_64bits_update (XXH3_state_t* statePtr, const void* input, size_t length); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@791 PS25, Line 791: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSeed(const void* data, size_t len, XXH64_hash_t seed); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@792 PS25, Line 792: XXH_PUBLIC_API XXH128_hash_t XXH3_128bits_withSecret(const void* data, size_t len, const void* secret, size_t secretSize); line too long (122 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@808 PS25, Line 808: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSeed(XXH3_state_t* statePtr, XXH64_hash_t seed); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@809 PS25, Line 809: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize); line too long (122 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@811 PS25, Line 811: XXH_PUBLIC_API XXH_errorcode XXH3_128bits_update (XXH3_state_t* statePtr, const void* input, size_t length); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@881 PS25, Line 881: XXH32_hash_t large_len; /*!< Whether the hash is >= 16 (handles @ref total_len_32 overflow) */ line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@886 PS25, Line 886: XXH32_hash_t mem32[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[16]. */ line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@888 PS25, Line 888: XXH32_hash_t reserved; /*!< Reserved field. Do not read or write to it, it may be removed. */ line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@912 PS25, Line 912: XXH64_hash_t mem64[4]; /*!< Internal buffer for partial reads. Treated as unsigned char[32]. */ line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@915 PS25, Line 915: XXH64_hash_t reserved64; /*!< Reserved field. Do not read or write to it, it may be removed. */ line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@977 PS25, Line 977: /*!< The 8 accumulators. Similar to `vN` in @ref XXH32_state_s::v1 and @ref XXH64_state_s */ line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1028 PS25, Line 1028: * The `_withSecret()` variants are useful to provide a higher level of protection than 64-bit seed, line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1029 PS25, Line 1029: * as it becomes much more difficult for an external actor to guess how to impact the calculation logic. line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1046 PS25, Line 1046: * and its content can be anything, even stupidly "low entropy" source such as a bunch of zeroes. line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1052 PS25, Line 1052: XXH_PUBLIC_API void XXH3_generateSecret(void* secretBuffer, const void* customSeed, size_t customSeedSize); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1257 PS25, Line 1257: #ifndef XXH_FORCE_MEMORY_ACCESS /* can be defined externally, on command line for example */ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1258 PS25, Line 1258: # if !defined(__clang__) && defined(__GNUC__) && defined(__ARM_FEATURE_UNALIGNED) && defined(__ARM_ARCH) && (__ARM_ARCH == 6) line too long (126 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1686 PS25, Line 1686: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u32*)ptr : XXH_swap32(*(const xxh_u32*)ptr); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1707 PS25, Line 1707: static const xxh_u32 XXH_PRIME32_1 = 0x9E3779B1U; /*!< 0b10011110001101110111100110110001 */ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1708 PS25, Line 1708: static const xxh_u32 XXH_PRIME32_2 = 0x85EBCA77U; /*!< 0b10000101111010111100101001110111 */ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1709 PS25, Line 1709: static const xxh_u32 XXH_PRIME32_3 = 0xC2B2AE3DU; /*!< 0b11000010101100101010111000111101 */ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1710 PS25, Line 1710: static const xxh_u32 XXH_PRIME32_4 = 0x27D4EB2FU; /*!< 0b00100111110101001110101100101111 */ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1711 PS25, Line 1711: static const xxh_u32 XXH_PRIME32_5 = 0x165667B1U; /*!< 0b00010110010101100110011110110001 */ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1771 PS25, Line 1771: * "+r" // constrain a read/write operand (+) as a general purpose register (r). line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1953 PS25, Line 1953: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */ line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1960 PS25, Line 1960: if ((((size_t)input) & 3) == 0) { /* Input is 4-bytes aligned, leverage the speed benefit */ line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1986 PS25, Line 1986: XXH_PUBLIC_API void XXH32_copyState(XXH32_state_t* dstState, const XXH32_state_t* srcState) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@1994 PS25, Line 1994: XXH32_state_t state; /* using a local state to memcpy() in order to avoid strict-aliasing warnings */ line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2030 PS25, Line 2030: XXH_memcpy((xxh_u8*)(state->mem32) + state->memsize, input, 16-state->memsize); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2155 PS25, Line 2155: # if (defined(__ILP32__) || defined(_ILP32)) /* ILP32 is often defined on 32-bit GCC family */ \ line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2158 PS25, Line 2158: || defined(__PPC64__) || defined(__PPC64LE__) || defined(__ppc64__) || defined(__powerpc64__) /* ppc64 */ \ line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2174 PS25, Line 2174: /* Force direct memory access. Only works on CPU which support unaligned memory access in hardware */ line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2278 PS25, Line 2278: return XXH_CPU_LITTLE_ENDIAN ? *(const xxh_u64*)ptr : XXH_swap64(*(const xxh_u64*)ptr); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2289 PS25, Line 2289: static const xxh_u64 XXH_PRIME64_1 = 0x9E3779B185EBCA87ULL; /*!< 0b1001111000110111011110011011000110000101111010111100101010000111 */ line too long (136 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2290 PS25, Line 2290: static const xxh_u64 XXH_PRIME64_2 = 0xC2B2AE3D27D4EB4FULL; /*!< 0b1100001010110010101011100011110100100111110101001110101101001111 */ line too long (136 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2291 PS25, Line 2291: static const xxh_u64 XXH_PRIME64_3 = 0x165667B19E3779F9ULL; /*!< 0b0001011001010110011001111011000110011110001101110111100111111001 */ line too long (136 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2292 PS25, Line 2292: static const xxh_u64 XXH_PRIME64_4 = 0x85EBCA77C2B2AE63ULL; /*!< 0b1000010111101011110010100111011111000010101100101010111001100011 */ line too long (136 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2293 PS25, Line 2293: static const xxh_u64 XXH_PRIME64_5 = 0x27D4EB2F165667C5ULL; /*!< 0b0010011111010100111010110010111100010110010101100110011111000101 */ line too long (136 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2494 PS25, Line 2494: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2514 PS25, Line 2514: /* Simple version, good for code maintenance, but unfortunately slow for small inputs */ line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2521 PS25, Line 2521: if ((((size_t)input) & 7)==0) { /* Input is aligned, let's leverage the speed advantage */ line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2545 PS25, Line 2545: XXH_PUBLIC_API void XXH64_copyState(XXH64_state_t* dstState, const XXH64_state_t* srcState) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2553 PS25, Line 2553: XXH64_state_t state; /* use a local state to memcpy() in order to avoid strict-aliasing warnings */ line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2587 PS25, Line 2587: XXH_memcpy(((xxh_u8*)state->mem64) + state->memsize, input, 32-state->memsize); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2637 PS25, Line 2637: h64 = XXH_rotl64(v1, 1) + XXH_rotl64(v2, 7) + XXH_rotl64(v3, 12) + XXH_rotl64(v4, 18); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2648 PS25, Line 2648: return XXH64_finalize(h64, (const xxh_u8*)state->mem64, (size_t)state->total_len, XXH_aligned); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@2852 PS25, Line 2852: # elif defined(__SSE2__) || defined(_M_AMD64) || defined(_M_X64) || (defined(_M_IX86_FP) && (_M_IX86_FP == 2)) line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3010 PS25, Line 3010: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3011 PS25, Line 3011: do { \ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3012 PS25, Line 3012: /* Undocumented GCC/Clang operand modifier: %e0 = lower D half, %f0 = upper D half */ \ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3013 PS25, Line 3013: /* https://github.com/gcc-mirror/gcc/blob/38cf91e5/gcc/config/arm/arm.c#L22486 */ \ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3014 PS25, Line 3014: /* https://github.com/llvm-mirror/llvm/blob/2c4ca683/lib/Target/ARM/ARMAsmPrinter.cpp#L399 */ \ line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3015 PS25, Line 3015: __asm__("vzip.32 %e0, %f0" : "+w" (in)); \ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3016 PS25, Line 3016: (outLo) = vget_low_u32 (vreinterpretq_u32_u64(in)); \ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3017 PS25, Line 3017: (outHi) = vget_high_u32(vreinterpretq_u32_u64(in)); \ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3020 PS25, Line 3020: # define XXH_SPLIT_IN_PLACE(in, outLo, outHi) \ line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3021 PS25, Line 3021: do { \ line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3022 PS25, Line 3022: (outLo) = vmovn_u64 (in); \ line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3023 PS25, Line 3023: (outHi) = vshrn_n_u64 ((in), 32); \ line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3062 PS25, Line 3062: # elif defined(__VEC_ELEMENT_REG_ORDER__) && __VEC_ELEMENT_REG_ORDER__ == __ORDER_BIG_ENDIAN__ line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3110 PS25, Line 3110: /* Clang has a better way to control this, we can just use the builtin which doesn't swap. */ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3137 PS25, Line 3137: # if defined(_MSC_VER) && (defined(_M_X64) || defined(_M_IX86)) /* _mm_prefetch() not defined outside of x86/x64 */ line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3138 PS25, Line 3138: # include <mmintrin.h> /* https://msdn.microsoft.com/fr-fr/library/84szxsww(v=vs.90).aspx */ line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3140 PS25, Line 3140: # elif defined(__GNUC__) && ( (__GNUC__ >= 4) || ( (__GNUC__ == 3) && (__GNUC_MINOR__ >= 1) ) ) line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3141 PS25, Line 3141: # define XXH_PREFETCH(ptr) __builtin_prefetch((ptr), 0 /* rw==read */, 3 /* locality */) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3160 PS25, Line 3160: 0xb8, 0xfe, 0x6c, 0x39, 0x23, 0xa4, 0x4b, 0xbe, 0x7c, 0x01, 0x81, 0x2c, 0xf7, 0x21, 0xad, 0x1c, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3161 PS25, Line 3161: 0xde, 0xd4, 0x6d, 0xe9, 0x83, 0x90, 0x97, 0xdb, 0x72, 0x40, 0xa4, 0xa4, 0xb7, 0xb3, 0x67, 0x1f, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3162 PS25, Line 3162: 0xcb, 0x79, 0xe6, 0x4e, 0xcc, 0xc0, 0xe5, 0x78, 0x82, 0x5a, 0xd0, 0x7d, 0xcc, 0xff, 0x72, 0x21, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3163 PS25, Line 3163: 0xb8, 0x08, 0x46, 0x74, 0xf7, 0x43, 0x24, 0x8e, 0xe0, 0x35, 0x90, 0xe6, 0x81, 0x3a, 0x26, 0x4c, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3164 PS25, Line 3164: 0x3c, 0x28, 0x52, 0xbb, 0x91, 0xc3, 0x00, 0xcb, 0x88, 0xd0, 0x65, 0x8b, 0x1b, 0x53, 0x2e, 0xa3, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3165 PS25, Line 3165: 0x71, 0x64, 0x48, 0x97, 0xa2, 0x0d, 0xf9, 0x4e, 0x38, 0x19, 0xef, 0x46, 0xa9, 0xde, 0xac, 0xd8, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3166 PS25, Line 3166: 0xa8, 0xfa, 0x76, 0x3f, 0xe3, 0x9c, 0x34, 0x3f, 0xf9, 0xdc, 0xbb, 0xc7, 0xc7, 0x0b, 0x4f, 0x1d, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3167 PS25, Line 3167: 0x8a, 0x51, 0xe0, 0x4b, 0xcd, 0xb4, 0x59, 0x31, 0xc8, 0x9f, 0x7e, 0xc9, 0xd9, 0x78, 0x73, 0x64, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3168 PS25, Line 3168: 0xea, 0xc5, 0xac, 0x83, 0x34, 0xd3, 0xeb, 0xc3, 0xc5, 0x81, 0xa0, 0xff, 0xfa, 0x13, 0x63, 0xeb, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3169 PS25, Line 3169: 0x17, 0x0d, 0xdd, 0x51, 0xb7, 0xf0, 0xda, 0x49, 0xd3, 0x16, 0x55, 0x26, 0x29, 0xd4, 0x68, 0x9e, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3170 PS25, Line 3170: 0x2b, 0x16, 0xbe, 0x58, 0x7d, 0x47, 0xa1, 0xfc, 0x8f, 0xf8, 0xb8, 0xd1, 0x7a, 0xd0, 0x31, 0xce, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3171 PS25, Line 3171: 0x45, 0xcb, 0x3a, 0x8f, 0x95, 0x16, 0x04, 0x28, 0xaf, 0xd7, 0xfb, 0xca, 0xbb, 0x4b, 0x40, 0x7e, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3419 PS25, Line 3419: XXH3_len_1to3_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3441 PS25, Line 3441: XXH3_len_4to8_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3457 PS25, Line 3457: XXH3_len_9to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3462 PS25, Line 3462: { xxh_u64 const bitflip1 = (XXH_readLE64(secret+24) ^ XXH_readLE64(secret+32)) + seed; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3463 PS25, Line 3463: xxh_u64 const bitflip2 = (XXH_readLE64(secret+40) ^ XXH_readLE64(secret+48)) - seed; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3474 PS25, Line 3474: XXH3_len_0to16_64b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3480 PS25, Line 3480: return XXH64_avalanche(seed ^ (XXH_readLE64(secret+56) ^ XXH_readLE64(secret+64))); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3618 PS25, Line 3618: acc += XXH3_mix16B(input+(16*i), secret+(16*(i-8)) + XXH3_MIDSIZE_STARTOFFSET, seed); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3621 PS25, Line 3621: acc += XXH3_mix16B(input + len - 16, secret + XXH3_SECRET_SIZE_MIN - XXH3_MIDSIZE_LASTOFFSET, seed); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3705 PS25, Line 3705: __m512i const data_key_lo = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1)); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3709 PS25, Line 3709: __m512i const data_swap = _mm512_shuffle_epi32(data_vec, (_MM_PERM_ENUM)_MM_SHUFFLE(1, 0, 3, 2)); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3754 PS25, Line 3754: __m512i const data_key_hi = _mm512_shuffle_epi32 (data_key, (_MM_PERM_ENUM)_MM_SHUFFLE(0, 3, 0, 1)); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3769 PS25, Line 3769: __m512i const seed = _mm512_mask_set1_epi64(_mm512_set1_epi64((xxh_i64)seed64), 0xAA, -(xxh_i64)seed64); line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3782 PS25, Line 3782: dest[i] = _mm512_add_epi64(_mm512_stream_load_si512(remote_const_void.p), seed); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3818 PS25, Line 3818: __m256i const data_key_lo = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1)); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3822 PS25, Line 3822: __m256i const data_swap = _mm256_shuffle_epi32(data_vec, _MM_SHUFFLE(1, 0, 3, 2)); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3850 PS25, Line 3850: __m256i const data_key_hi = _mm256_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1)); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3858 PS25, Line 3858: XXH_FORCE_INLINE XXH_TARGET_AVX2 void XXH3_initCustomSecret_avx2(void* XXH_RESTRICT customSecret, xxh_u64 seed64) line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3865 PS25, Line 3865: { __m256i const seed = _mm256_set_epi64x(-(xxh_i64)seed64, (xxh_i64)seed64, -(xxh_i64)seed64, (xxh_i64)seed64); line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3926 PS25, Line 3926: __m128i const data_key_lo = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1)); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3958 PS25, Line 3958: __m128i const data_key_hi = _mm_shuffle_epi32 (data_key, _MM_SHUFFLE(0, 3, 0, 1)); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@3966 PS25, Line 3966: XXH_FORCE_INLINE XXH_TARGET_SSE2 void XXH3_initCustomSecret_sse2(void* XXH_RESTRICT customSecret, xxh_u64 seed64) line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4101 PS25, Line 4101: xxh_u64x2 const* const xinput = (xxh_u64x2 const*) input; /* no alignment restriction */ line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4102 PS25, Line 4102: xxh_u64x2 const* const xsecret = (xxh_u64x2 const*) secret; /* no alignment restriction */ line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4113 PS25, Line 4113: /* product = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)shuffled & 0xFFFFFFFF); */ line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4136 PS25, Line 4136: xxh_u32x4 const prime = { XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1, XXH_PRIME32_1 }; line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4148 PS25, Line 4148: /* prod_lo = ((xxh_u64x2)data_key & 0xFFFFFFFF) * ((xxh_u64x2)prime & 0xFFFFFFFF); */ line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4181 PS25, Line 4181: XXH_ALIGN(XXH_ACC_ALIGN) xxh_u64* const xacc = (xxh_u64*) acc; /* presumed aligned */ line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4346 PS25, Line 4346: size_t const nbStripesPerBlock = (secretSize - XXH_STRIPE_LEN) / XXH_SECRET_CONSUME_RATE; line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4367 PS25, Line 4367: #define XXH_SECRET_LASTACC_START 7 /* not aligned on 8, last secret is different from acc & scrambler */ line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4368 PS25, Line 4368: f_acc512(acc, p, secret + secretSize - XXH_STRIPE_LEN - XXH_SECRET_LASTACC_START); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4381 PS25, Line 4381: XXH3_mergeAccs(const xxh_u64* XXH_RESTRICT acc, const xxh_u8* XXH_RESTRICT secret, xxh_u64 start) line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4418 PS25, Line 4418: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, (const xxh_u8*)secret, secretSize, f_acc512, f_scramble); line too long (121 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4425 PS25, Line 4425: return XXH3_mergeAccs(acc, (const xxh_u8*)secret + XXH_SECRET_MERGEACCS_START, (xxh_u64)len * XXH_PRIME64_1); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4433 PS25, Line 4433: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen) line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4436 PS25, Line 4436: return XXH3_hashLong_64b_internal(input, len, secret, secretLen, XXH3_accumulate_512, XXH3_scrambleAcc); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4448 PS25, Line 4448: XXH64_hash_t seed64, const xxh_u8* XXH_RESTRICT secret, size_t secretLen) line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4451 PS25, Line 4451: return XXH3_hashLong_64b_internal(input, len, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_accumulate_512, XXH3_scrambleAcc); line too long (125 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4497 PS25, Line 4497: XXH64_hash_t, const xxh_u8* XXH_RESTRICT, size_t); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4501 PS25, Line 4501: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4513 PS25, Line 4513: return XXH3_len_0to16_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4515 PS25, Line 4515: return XXH3_len_17to128_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4517 PS25, Line 4517: return XXH3_len_129to240_64b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4527 PS25, Line 4527: return XXH3_64bits_internal(input, len, 0, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_default); line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4532 PS25, Line 4532: XXH3_64bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4534 PS25, Line 4534: return XXH3_64bits_internal(input, len, 0, secret, secretSize, XXH3_hashLong_64b_withSecret); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4541 PS25, Line 4541: return XXH3_64bits_internal(input, len, seed, XXH3_kSecret, sizeof(XXH3_kSecret), XXH3_hashLong_64b_withSeed); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4615 PS25, Line 4615: XXH3_state_t* const state = (XXH3_state_t*)XXH_alignedMalloc(sizeof(XXH3_state_t), 64); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4672 PS25, Line 4672: XXH3_64bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize) line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4694 PS25, Line 4694: * so that the function can blindly consume all stripes using the "normal" secret segment */ line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4703 PS25, Line 4703: XXH_ASSERT(nbStripes <= nbStripesPerBlock); /* can handle max 1 scramble per invocation */ line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4709 PS25, Line 4709: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripesToEndofBlock, f_acc512); line too long (126 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4711 PS25, Line 4711: XXH3_accumulate(acc, input + nbStripesToEndofBlock * XXH_STRIPE_LEN, secret, nbStripesAfterBlock, f_acc512); line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4714 PS25, Line 4714: XXH3_accumulate(acc, input, secret + nbStripesSoFarPtr[0] * XXH_SECRET_CONSUME_RATE, nbStripes, f_acc512); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4736 PS25, Line 4736: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret; line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4741 PS25, Line 4741: if (state->bufferedSize + len <= XXH3_INTERNALBUFFER_SIZE) { /* fill in tmp buffer */ line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4749 PS25, Line 4749: XXH_STATIC_ASSERT(XXH3_INTERNALBUFFER_SIZE % XXH_STRIPE_LEN == 0); /* clean multiple */ line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4780 PS25, Line 4780: memcpy(state->buffer + sizeof(state->buffer) - XXH_STRIPE_LEN, input - XXH_STRIPE_LEN, XXH_STRIPE_LEN); line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4827 PS25, Line 4827: memcpy(lastStripe, state->buffer + sizeof(state->buffer) - catchupSize, catchupSize); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4838 PS25, Line 4838: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret; line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4873 PS25, Line 4873: XXH_ASSERT(segmentSize * nbSegments == XXH_SECRET_DEFAULT_SIZE); /* exact multiple */ line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4894 PS25, Line 4894: XXH128(&scrambler, sizeof(scrambler), XXH_readLE64(seeds + segnb) + segnb) ); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4918 PS25, Line 4918: XXH3_len_1to3_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4936 PS25, Line 4936: xxh_u64 const bitfliph = (XXH_readLE32(secret+8) ^ XXH_readLE32(secret+12)) - seed; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4947 PS25, Line 4947: XXH3_len_4to8_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4956 PS25, Line 4956: xxh_u64 const bitflip = (XXH_readLE64(secret+16) ^ XXH_readLE64(secret+24)) + seed; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4974 PS25, Line 4974: XXH3_len_9to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4979 PS25, Line 4979: { xxh_u64 const bitflipl = (XXH_readLE64(secret+32) ^ XXH_readLE64(secret+40)) - seed; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4980 PS25, Line 4980: xxh_u64 const bitfliph = (XXH_readLE64(secret+48) ^ XXH_readLE64(secret+56)) + seed; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@4983 PS25, Line 4983: XXH128_hash_t m128 = XXH_mult64to128(input_lo ^ input_hi ^ bitflipl, XXH_PRIME64_1); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5004 PS25, Line 5004: m128.high64 += (input_hi & 0xFFFFFFFF00000000ULL) + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2); line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5030 PS25, Line 5030: m128.high64 += input_hi + XXH_mult32to64((xxh_u32)input_hi, XXH_PRIME32_2 - 1); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5049 PS25, Line 5049: XXH3_len_0to16_128b(const xxh_u8* input, size_t len, const xxh_u8* secret, XXH64_hash_t seed) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5169 PS25, Line 5169: XXH3_hashLong_internal_loop(acc, (const xxh_u8*)input, len, secret, secretSize, f_acc512, f_scramble); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5225 PS25, Line 5225: return XXH3_hashLong_128b_internal(input, len, (const xxh_u8*)secret, sizeof(secret), line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5235 PS25, Line 5235: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen) line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5243 PS25, Line 5243: XXH64_hash_t, const void* XXH_RESTRICT, size_t); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5247 PS25, Line 5247: XXH64_hash_t seed64, const void* XXH_RESTRICT secret, size_t secretLen, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5258 PS25, Line 5258: return XXH3_len_0to16_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, seed64); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5260 PS25, Line 5260: return XXH3_len_17to128_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5262 PS25, Line 5262: return XXH3_len_129to240_128b((const xxh_u8*)input, len, (const xxh_u8*)secret, secretLen, seed64); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5279 PS25, Line 5279: XXH3_128bits_withSecret(const void* input, size_t len, const void* secret, size_t secretSize) line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5321 PS25, Line 5321: XXH3_128bits_reset_withSecret(XXH3_state_t* statePtr, const void* secret, size_t secretSize) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5352 PS25, Line 5352: const unsigned char* const secret = (state->extSecret == NULL) ? state->customSecret : state->extSecret; line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5356 PS25, Line 5356: XXH_ASSERT(state->secretLimit + XXH_STRIPE_LEN >= sizeof(acc) + XXH_SECRET_MERGEACCS_START); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/be/src/thirdparty/xxhash/xxhash.h@5363 PS25, Line 5363: - sizeof(acc) - XXH_SECRET_MERGEACCS_START, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17026/25/common/thrift/parquet.thrift File common/thrift/parquet.thrift: http://gerrit.cloudera.org:8080/#/c/17026/25/common/thrift/parquet.thrift@656 PS25, Line 656: /** Compressed (and potentially encrypted) page size in bytes, not including this header **/ line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7119c7161fa3658e561fc1265430cb90079d8287 Gerrit-Change-Number: 17026 Gerrit-PatchSet: 25 Gerrit-Owner: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Apr 2021 15:58:18 +0000 Gerrit-HasComments: Yes
