Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17187 )

Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory 
config.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17187/1/be/src/exec/buffered-plan-root-sink.cc
File be/src/exec/buffered-plan-root-sink.cc:

http://gerrit.cloudera.org:8080/#/c/17187/1/be/src/exec/buffered-plan-root-sink.cc@55
PS1, Line 55:   if (max_spilled_mem <= 0) max_spilled_mem = INT64_MAX;
> In practice, this would eventually encounter other limits such as running o
The closest limit I find is scratch_dirs startup flag. In this flag, we define 
the path of scratch dirs and capacity quota (maximum bytes allowed to spill) 
for each dirs. But the quota specification itself is optional. So without quota 
being specified, I suppose we depend on OS to tell impala when disk space has 
ran out.
https://impala.apache.org/docs/build/html/topics/impala_disk_space.html



--
To view, visit http://gerrit.cloudera.org:8080/17187
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8f5e3668281bba8813f8082f45b4faa7721530e
Gerrit-Change-Number: 17187
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 17:26:32 +0000
Gerrit-HasComments: Yes

Reply via email to