Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17306 )
Change subject: IMPALA-10445: Adjust NDV's precision/scale by query option ...................................................................... Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java File fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java: http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java@13 PS1, Line 13: public static org.apache.impala.rewrite.CountDistinctToNdvRule INSTANCE = new org.apache.impala.rewrite.CountDistinctToNdvRule(); line too long (133 > 90) http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java@25 PS1, Line 25: if (!analyzer.getQueryCtx().client_request.query_options.appx_count_distinct) return expr; line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java@31 PS1, Line 31: || !oldFunctionCallExpr.isDistinct() || oldFunctionCallExpr.getParams().exprs().size() != 1 ) { line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java@36 PS1, Line 36: FunctionCallExpr ndvFunc = new FunctionCallExpr("ndv", oldFunctionCallExpr.getParams().exprs()); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/main/java/org/apache/impala/rewrite/DefaultNdvScaleRule.java File fe/src/main/java/org/apache/impala/rewrite/DefaultNdvScaleRule.java: http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/main/java/org/apache/impala/rewrite/DefaultNdvScaleRule.java@28 PS1, Line 28: * changes were made, the transformed Expr is guaranteed to be a different Expr object, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java File fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java: http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@521 PS1, Line 521: assertToSql(createAnalysisCtx(options), countDistinctSql, countDistinctSql, "SELECT ndv(id) FROM functional.alltypes"); line too long (123 > 90) http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@525 PS1, Line 525: assertToSql(createAnalysisCtx(options), countDistinctSql, countDistinctSql, "SELECT ndv(id, 10) FROM functional.alltypes"); line too long (127 > 90) http://gerrit.cloudera.org:8080/#/c/17306/1/fe/src/test/java/org/apache/impala/analysis/ExprRewriterTest.java@535 PS1, Line 535: assertToSql(createAnalysisCtx(options), ndvSql, ndvSql, "SELECT ndv(id, 9) FROM functional.alltypes"); line too long (106 > 90) -- To view, visit http://gerrit.cloudera.org:8080/17306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1669858a6e8252e167b464586e8d0b6cb0d0bd50 Gerrit-Change-Number: 17306 Gerrit-PatchSet: 1 Gerrit-Owner: fifteencai <fifteen...@tencent.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Apr 2021 13:29:15 +0000 Gerrit-HasComments: Yes
