Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17289 )
Change subject: IMPALA-10532: TestOverlapMinMaxFilters.test_overlap_min_max_filters seems flaky ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17289/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17289/2//COMMIT_MSG@10 PS2, Line 10: due to the query plan change (from 3-node scan to : 2-node scan) which splits the row groups among scan nodes differently. > One more piece of details on instance 2. The overlap ratio of 0 indicates t Ah, I see! Thanks for the detailed explanation! It's really helpful. http://gerrit.cloudera.org:8080/#/c/17289/2/tests/query_test/test_runtime_filters.py File tests/query_test/test_runtime_filters.py: http://gerrit.cloudera.org:8080/#/c/17289/2/tests/query_test/test_runtime_filters.py@270 PS2, Line 270: @SkipIfNotHdfsMinicluster.scheduling IIUC, the issue is due to the underlying parquet files have different stats between EC and non-EC runs. It's not about scheduling. So I suggest we add a new skip type in SkipIfEC and use that instead, e.g. SkipIfEC.different_stats, and adding this in SkipIfEC (tests/common/skip.py) different_stats = pytest.mark.skipif(IS_EC, reason="Parquet/ORC files that are generated" " in tests have different stats in EC mode due to larger block group size.") -- To view, visit http://gerrit.cloudera.org:8080/17289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I527de530f7db1ce959e7ef2ae3ced18677221c9f Gerrit-Change-Number: 17289 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Apr 2021 02:15:53 +0000 Gerrit-HasComments: Yes
