Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17331 )
Change subject: IMPALA-10669: Limit memory during dataload in Docker-based tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17331/1/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/17331/1/docker/test-with-docker.py@648 PS1, Line 648: # Tez can get confused when creating ORC files with nested structures : # on machines with lots of RAM, e.g. m5.12xlarge. Limiting the available memory : # seems to avoid this problem, so limit container memory just for the build : # container. 128GB is still much more than dataload needs, but does the trick. : extras=["-m", "128g"], > Should we make this conditional on the machine having more than 128g of mem My (admittedly) assumption was that on a machine that has less memory this option would be a no-op. I'll check/research. -- To view, visit http://gerrit.cloudera.org:8080/17331 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5100589ffc54184b6ca13db139cb983175c934eb Gerrit-Change-Number: 17331 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Apr 2021 09:56:58 +0000 Gerrit-HasComments: Yes
