Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 )
Change subject: IMPALA-7825: Upgrade Thrift version to 0.11.0 ...................................................................... Patch Set 16: (5 comments) http://gerrit.cloudera.org:8080/#/c/17170/16/bin/impala-shell.sh File bin/impala-shell.sh: http://gerrit.cloudera.org:8080/#/c/17170/16/bin/impala-shell.sh@30 PS16, Line 30: thrift-11-gen This dir no longer exists, which causes the data-loading failure that impala-shell can't import beeswaxd. I think we should use ${SHELL_HOME}/gen-py here. http://gerrit.cloudera.org:8080/#/c/17170/16/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/17170/16/shell/impala_client.py@1149 PS16, Line 1149: type(row) == str nit: isinstance(row, str) http://gerrit.cloudera.org:8080/#/c/17170/16/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/17170/16/shell/impala_shell.py@1143 PS16, Line 1143: type(col) == str nit: isinstance(col, str) http://gerrit.cloudera.org:8080/#/c/17170/16/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/17170/16/shell/shell_output.py@44 PS16, Line 44: type(entry) == str nit: isinstance(entry, str) http://gerrit.cloudera.org:8080/#/c/17170/16/shell/shell_output.py@90 PS16, Line 90: type(val) == unicode nit: isinstance(val, unicode) -- To view, visit http://gerrit.cloudera.org:8080/17170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd13f177b4f7acc07872ea6399035aa180ef6ab6 Gerrit-Change-Number: 17170 Gerrit-PatchSet: 16 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Apr 2021 05:44:29 +0000 Gerrit-HasComments: Yes
