Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17303 )
Change subject: IMPALA-10654: Fix precision loss in DecimalValue to double conversion. ...................................................................... Patch Set 5: > (4 comments) > > The change looks great. A test with Parquet would be nice, other > than that I only found nitpicks. > > When you upload a new PS please reply to the comments. Most of the > time clicking on "Done" is enough. This way we'll know we won't > left anything open. I did reply to the comments but didn't know the reply gets saved as draft and needs explicit post later. Sorry about that. I figured that out now, so you might get some old replies too. -- To view, visit http://gerrit.cloudera.org:8080/17303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56f0652cb8f81a491b87d9b108a94c00ae6c99a1 Gerrit-Change-Number: 17303 Gerrit-PatchSet: 5 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Apr 2021 12:36:05 +0000 Gerrit-HasComments: No
