Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17333 )
Change subject: IMPALA-10672: Fix non-deterministic RANK queries in tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17333/1/testdata/workloads/tpch/queries/limit-pushdown-analytic.test File testdata/workloads/tpch/queries/limit-pushdown-analytic.test: http://gerrit.cloudera.org:8080/#/c/17333/1/testdata/workloads/tpch/queries/limit-pushdown-analytic.test@98 PS1, Line 98: l_linenumber Just a quick question here, is my assumption correct that the l_linenumber is needed because the l_orderkey alone is not unique in the partitions? -- To view, visit http://gerrit.cloudera.org:8080/17333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I396549f2ba3928cb4db942def9fae6504266d344 Gerrit-Change-Number: 17333 Gerrit-PatchSet: 1 Gerrit-Owner: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Tue, 27 Apr 2021 08:14:11 +0000 Gerrit-HasComments: Yes
