Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17348 )
Change subject: IMPALA-10471: Making deadline for Shutdown by SIGRTMIN configurable ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17348/2/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/17348/2/tests/custom_cluster/test_restart_services.py@603 PS2, Line 603: > Thanks Tamas for the review. Just for my clarification, as self.EXEC_SHUTDO Ah, got your point, yes this should have the +2 spaces. In general when the style is ambiguous we use the code around to decide the formatting, I just scrolled a bit up for other reference and my eyes fixated on test_shutdown_coordinator. -- To view, visit http://gerrit.cloudera.org:8080/17348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52cb1ba76e7ce9de86ceb2f84389b1ab257e4c05 Gerrit-Change-Number: 17348 Gerrit-PatchSet: 2 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Comment-Date: Wed, 28 Apr 2021 13:50:24 +0000 Gerrit-HasComments: Yes
