Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17038 )
Change subject: IMPALA-10482, IMPALA-10493: Fix bugs in full ACID collection query rewrites ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17038/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17038/3//COMMIT_MSG@34 PS3, Line 34: When AcidRewriter.splitCollectionRef() creates a new collection ref : it doesn't copy every information needed to correctly execute the : query. E.g. it dropped the ON clause, turning INNER joins to CROSS : joins. > We faced the same problem in column masking, and made a tricky way to resol Thanks for the explanation. I've opened IMPALA-10685 to track the above issue. -- To view, visit http://gerrit.cloudera.org:8080/17038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fc758d3c1e75c7066936d590aec8bff8d2b00b0 Gerrit-Change-Number: 17038 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 29 Apr 2021 18:45:15 +0000 Gerrit-HasComments: Yes