Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17295 )
Change subject: IMPALA-10650: Bailout min/max filters in hash join builder early ...................................................................... Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/17295/8/be/src/exec/partitioned-hash-join-builder.cc File be/src/exec/partitioned-hash-join-builder.cc: http://gerrit.cloudera.org:8080/#/c/17295/8/be/src/exec/partitioned-hash-join-builder.cc@329 PS8, Line 329: DetermineUsefulnessForMinmaxFilters(); > The method FilterContext::ShouldRejectFilterBasedOnColumnStats() is calle Yeah, it's O(1) in complexity. But unpredictable branches are harmful for mordern CPUs that have pipelines. It seems we don't need over-optimization on this since it's not in the hot path. Let's skip this. http://gerrit.cloudera.org:8080/#/c/17295/8/be/src/exec/partitioned-hash-join-builder.cc@351 PS8, Line 351: VLOG(3) > Double checked with the ClangFormat which produces the above spacing. hmm.. I'm following this: https://google.github.io/styleguide/cppguide.html#Function_Calls. It's used by our c++ style: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=65868536 Maybe clang-format didn't check the continuation indent width. But existing codes (e.g. line 391, 399 in this PS) use 4 spaces indent width. http://gerrit.cloudera.org:8080/#/c/17295/20/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/17295/20/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@267 PS20, Line 267: minMaxValuePresent I have a newbie question for the min-max filter: do we have a way (e.g. a query option) to disable using the min-max stats if users find they are stale? -- To view, visit http://gerrit.cloudera.org:8080/17295 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I193646e7acfdd3023f7c947d8107da58a1f41183 Gerrit-Change-Number: 17295 Gerrit-PatchSet: 20 Gerrit-Owner: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Sat, 08 May 2021 08:12:09 +0000 Gerrit-HasComments: Yes
