Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17406 )
Change subject: IMPALA-9690: Set minimum CPU requirement to AVX2 for x86_64 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) There are still some places where things like CpuInfo::IsSupported(CpuInfo::SSE4_2) is present. I assume you're saving those for a follow-on commit? http://gerrit.cloudera.org:8080/#/c/17406/2/be/src/codegen/CMakeLists.txt File be/src/codegen/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/17406/2/be/src/codegen/CMakeLists.txt@68 PS2, Line 68: set(PLATFORM_SPECIFIC_FLAGS "-mavx2") Does this imply POPCNT, as used in bit-util? -- To view, visit http://gerrit.cloudera.org:8080/17406 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6de2e897d8ff24dea3c7c1c4ab9d61734839835d Gerrit-Change-Number: 17406 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Sat, 08 May 2021 16:32:44 +0000 Gerrit-HasComments: Yes
