Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17416 )
Change subject: IMPALA-10401: Enable Ranger audit logs to log4j ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Thanks Quanlong for working on this! This patch would make it much easier for us to investigate flaky tests. I only have 2 very minor comments. http://gerrit.cloudera.org:8080/#/c/17416/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17416/1//COMMIT_MSG@10 PS1, Line 10: provides us nit: provides us with http://gerrit.cloudera.org:8080/#/c/17416/1//COMMIT_MSG@16 PS1, Line 16: catalogd, cooridnator According to https://github.com/apache/impala/blame/master/bin/create-test-configuration.sh#L148-L158, ranger-hive-audit.xml will also be used when we start an authorization-enabled HiveServer2 (IMPALA-9304). Is it true that we would also see the Ranger audits in files like hive-server2.log? -- To view, visit http://gerrit.cloudera.org:8080/17416 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e6850882594f31dc2250fe205fa6cad26a30571 Gerrit-Change-Number: 17416 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Comment-Date: Tue, 11 May 2021 04:45:11 +0000 Gerrit-HasComments: Yes
