Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17389 )
Change subject: IMPALA-10680: Replace StringToFloatInternal using fast_double_parser library ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17389/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17389/2//COMMIT_MSG@13 PS2, Line 13: speed > It would be nice to have some measurements, for example by adding a large n Sure, will try to measure it. Theoretically, this should not improve performance but just improve the accuracy without perf penalty. http://gerrit.cloudera.org:8080/#/c/17389/2//COMMIT_MSG@17 PS2, Line 17: 2. Ran existing Backend tests for correctness. > Can you add some tests to https://github.com/apache/impala/blob/master/be/s I have added them now. Thanks for the suggestion. -- To view, visit http://gerrit.cloudera.org:8080/17389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic105ad38a2fcbf2fb4e8ae8af6d9a8e251a9c141 Gerrit-Change-Number: 17389 Gerrit-PatchSet: 3 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 11 May 2021 11:44:54 +0000 Gerrit-HasComments: Yes
