Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17464 )
Change subject: IMPALA-10679: Add builtin functions to comptute SHA-1 and SHA-2 digest. ...................................................................... Patch Set 4: (2 comments) Thanks for the review, Zoltan. Have done the required changes. http://gerrit.cloudera.org:8080/#/c/17464/3/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/17464/3/be/src/exprs/expr-test.cc@5582 PS3, Line 5582: TestStringValue(sha2fn + ", 512)", expected); > Please add some tests with some special values, e.g. NULL, empty string Done http://gerrit.cloudera.org:8080/#/c/17464/3/be/src/exprs/utility-functions-ir.cc File be/src/exprs/utility-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/17464/3/be/src/exprs/utility-functions-ir.cc@264 PS3, Line 264: x->SetError("O > What is the return value of SHA* functions and why we ignore it? It returns pointer to the hash. We don't need return value here as sha-hash.ptr points to the same. I have removed it for now as sha functions are not attributed as `warn_unused_result`. -- To view, visit http://gerrit.cloudera.org:8080/17464 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If163b7abda17cca3074c86519d59bcfc6ace21be Gerrit-Change-Number: 17464 Gerrit-PatchSet: 4 Gerrit-Owner: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Amogh Margoor <amarg...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 17 May 2021 19:03:18 +0000 Gerrit-HasComments: Yes
