Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17398 )
Change subject: IMPALA-10485: Support Iceberg field-id based column resolution in the ORC scanner ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17398/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17398/1//COMMIT_MSG@10 PS1, Line 10: field-id > Could you add that this becomes the default for Iceberg tables as well? Done http://gerrit.cloudera.org:8080/#/c/17398/1/be/src/exec/orc-metadata-utils.h File be/src/exec/orc-metadata-utils.h: http://gerrit.cloudera.org:8080/#/c/17398/1/be/src/exec/orc-metadata-utils.h@62 PS1, Line 62: enum SchemaResolutionStrategy { : POSITION, : ICEBERG_FIELD_ID : }; > Do you think this would worth to be generalized with TParquetFallbackSchema Yeah, I renamed TParquetFallbackSchemaResolution to TSchemaResolutionStrategy and use it in both scanners. -- To view, visit http://gerrit.cloudera.org:8080/17398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia2b1abcc25ad2268aa96dff032328e8951dbfb9d Gerrit-Change-Number: 17398 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Tue, 18 May 2021 17:04:46 +0000 Gerrit-HasComments: Yes
