Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17332 )
Change subject: IMPALA-9155: Add recovery mechanism to admission service ...................................................................... Patch Set 1: (3 comments) I read through the code once, saving my nits here http://gerrit.cloudera.org:8080/#/c/17332/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17332/1//COMMIT_MSG@12 PS1, Line 12: - No RPCs are serviced by a coordinator unless it sends its complete Nit" should this be "No RPCs are serviced from a coordinator until it has sent"? http://gerrit.cloudera.org:8080/#/c/17332/1/common/protobuf/admission_control_service.proto File common/protobuf/admission_control_service.proto: http://gerrit.cloudera.org:8080/#/c/17332/1/common/protobuf/admission_control_service.proto@280 PS1, Line 280: /// those situations. An error response is sent if the coordinator has not yet sent a Move new comment to before the TODO to clarify that it is not part of the TODO http://gerrit.cloudera.org:8080/#/c/17332/1/common/protobuf/admission_control_service.proto@301 PS1, Line 301: /// ReleaseQuery. An error response is sent if the coordinator has not yet sent a Move new comment to before the TODO to clarify that it is not part of the TODO -- To view, visit http://gerrit.cloudera.org:8080/17332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ad3ef9b9e2496c484833d6326ce914c851e02fd Gerrit-Change-Number: 17332 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Wed, 19 May 2021 21:28:52 +0000 Gerrit-HasComments: Yes
