Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17469 )

Change subject: IMPALA-9770: [DOCS] Remove Sentry references in documentation
......................................................................


Patch Set 1:

(4 comments)

Thanks Joe for the question regarding SET OWNER ROLE! This syntax is supported 
but the functionality is not due to IMPALA-10712.

I am still reviewing this patch. But I think in the meantime Shajini could 
start addressing Joe's current comments if that is possible. I will quickly go 
through the patch and provide my feedback. Thanks.

http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_database.xml
File docs/topics/impala_alter_database.xml:

http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_database.xml@a68
PS1, Line 68:
> I think we still support this variant. Fang-Yu, can you confirm?
Thanks Joe! The syntax is supported however the functionality is not due to 
IMPALA-10712.


http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_table.xml
File docs/topics/impala_alter_table.xml:

http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_table.xml@a74
PS1, Line 74:
> I think we still support this variant. Fang-Yu, can you confirm?
Thanks Joe! The syntax is supported however the functionality is not due to 
IMPALA-10712.


http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_table.xml@a322
PS1, Line 322:
> Same as above
Thanks Joe! The syntax is supported however the functionality is not due to 
IMPALA-10712.


http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_view.xml
File docs/topics/impala_alter_view.xml:

http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_view.xml@a71
PS1, Line 71:
> I think we still support this variant. Fang-Yu, can you confirm?
Thanks Joe! The syntax is supported however the functionality is not due to 
IMPALA-10712.



--
To view, visit http://gerrit.cloudera.org:8080/17469
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4c5e9aa4d060ceaa426908a444d280a5564749d
Gerrit-Change-Number: 17469
Gerrit-PatchSet: 1
Gerrit-Owner: Shajini Thayasingh <sthayasi...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 May 2021 00:38:25 +0000
Gerrit-HasComments: Yes

Reply via email to