wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17466 )
Change subject: IMPALA-10626: Add support for Iceberg's Catalogs API ...................................................................... Patch Set 2: (4 comments) Thanks for new feature! http://gerrit.cloudera.org:8080/#/c/17466/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17466/2//COMMIT_MSG@12 PS2, Line 12: contiain contain? http://gerrit.cloudera.org:8080/#/c/17466/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/17466/2/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@677 PS2, Line 677: throws AnalysisException Exception never thrown in this method. http://gerrit.cloudera.org:8080/#/c/17466/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java: http://gerrit.cloudera.org:8080/#/c/17466/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalog.java@58 PS2, Line 58: properties Maybe we should alse add some comments for this new parameter. http://gerrit.cloudera.org:8080/#/c/17466/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java: http://gerrit.cloudera.org:8080/#/c/17466/2/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergCatalogs.java@114 PS2, Line 114: properties Unused variable. -- To view, visit http://gerrit.cloudera.org:8080/17466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5dfa150986117fc55b28034c4eda38a736460ead Gerrit-Change-Number: 17466 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: wangsheng <sky...@163.com> Gerrit-Comment-Date: Fri, 21 May 2021 07:35:21 +0000 Gerrit-HasComments: Yes
